search

robcarver17 / pysystemtrade

Systematic Trading in python
GNU General Public License v3.0
2.6k stars 822 forks source link

Fixed code errors #1371

Closed Eeonum closed 3 months ago

Eeonum commented 5 months ago

diagPrices changed to diag_prices in rollcalendars_from_arcticprices_to_csv.py and multiple_and_adjusted_from_csv_to_arctic.py

tgibson11 commented 5 months ago

This pull request includes several other changes from your fork that you probably didn't intend to include. You'll need remove them before this can be merged.

Also, are you sure this should be merged into master rather than develop? The general idea is that most changes will be done in develop first, and develop will eventually be merged into master when it is considered to be reasonably stable.

Eeonum commented 5 months ago

It should be part of the master's as this is final. I tried to fix the redundancies, but can you remove adding the CSV files on your end if it didn't work? The rest should be added to the master.