search

robcast / digilib

A versatile image viewing environment for the internet.
https://robcast.github.io/digilib/
GNU Lesser General Public License v3.0
18 stars 7 forks source link

[manifester] url-encode plus signs in paths #21

Closed awagner-mainz closed 5 years ago

awagner-mainz commented 5 years ago

Today I found out that automatically generated manifests (for files like 'repo/ASVCCLD_001_0001+scala cromatica.jpg') refer to images without url-encoding plus signs in folder or file names. At some point in (at least) my setup,1 these seems to be translated into spaces, with the result of the respective file not being found. Obviously one way around this is to avoid using pluses in filenames.

But would it be possible to have the manifester encode '+' as '%2b' automatically? (I assume characters that are more strictly "url-unsafe" are encoded anyway.)

1 The setup in this case is, from user to server: mirador, chrome, caddy, digilib.

robcast commented 5 years ago

You seem to find all bugs with special characters in filenames ;-)

I'll check the encoding issue...

awagner-mainz commented 5 years ago

Cool. In my defense, I must say that I am not the one who is naming the files in the first place ;-) I will see if I manage to check out master or wait for the next release. Thank you a lot, I really do appreciate it!

robcast commented 5 years ago

Please try out master by building from source or use the snapshot docker image (see documentation). If you use the WAR you can try to take it out of the snapshot maven repo: https://github.com/robcast/digilib-repo/tree/gh-pages/maven-repo/digilib/digilib-webapp/2.8-SNAPSHOT