search

robclancy / presenter

Decorate your objects using presenters. Primarily to keep presentation logic out of your models.
MIT License
345 stars 38 forks source link

Update for 4.2 #26

Closed Anahkiasen closed 10 years ago

Anahkiasen commented 10 years ago

Since you're doing new View\Environment in the service provider and this class was renamed, it's all crashing n stuff on 4.2.

paulofreitas commented 10 years ago

+1

@robclancy That's by far the most useful presenter package I've found and one of the most downloaded packages at Packalyst. Keep it up! We could help you with PRs to fix those issues, but someone will need to merge them... Thank you anyway! :)

robclancy commented 10 years ago

I'll get this updated today or on the weekend. I have been busy and didn't even notice the email about this issue.

paulofreitas commented 10 years ago

@robclancy Thank you for your response! It's good to see that this awesome package will be updated soon! Thanks! :beers:

(Let me sorry if I seemed to be requiring you something, I think I might have badly expressed myself...)

Anahkiasen commented 10 years ago

@robclancy don't forget to squash your commits tho :winkwink:

robclancy commented 10 years ago

haha *gets tempted to break it up as much as possible

robclancy commented 10 years ago

Okay done on develop so you need to be using dev-master for this to work. When Laravel 4.2 becomes stable I will merge develop to be version 1.3.0.

paulofreitas commented 10 years ago

Okay, now it's working like a charm! Thanks again for all the effort you had put to keep it up! :) :beers:

ghost commented 10 years ago

Thank you!!!

kevinklika commented 10 years ago

I tried this and it did not work... I had to pull from dev-develop NOT dev-master