search

robclancy / presenter

Decorate your objects using presenters. Primarily to keep presentation logic out of your models.
MIT License
345 stars 38 forks source link

Updates for Laravel 5 #43

Closed impleri closed 7 years ago

impleri commented 9 years ago

While updating composer.json seems sufficient enough, This includes updating ViewFactory::make to match what's in illuminate/view and updating dependencies (Mockery and PHPUnit).

impleri commented 9 years ago

Guessing by the comment in #42, I'm pinging @robclancy for visibility without creating a separate issue.

Also, are you looking for a co-maintainer?

robclancy commented 9 years ago

This one was failing which is why I never looked at it. The other PR did barely anything so I was under the impression that was all that was needed. I will properly look into all this later today and make a proper release.

If I don't soon just bug me on here until I do as I may forget.

impleri commented 9 years ago

It was failing the StyleCI checks because the current codebase doesn't pass StyleCI ;)

robclancy commented 9 years ago

And never will, I think I integrated that to test it out and forgot to remove it.

On Thu, Mar 19, 2015 at 7:32 AM, Christopher Roussel < notifications@github.com> wrote:

It was failing the StyleCI checks because the current codebase doesn't pass StyleCI ;)

— Reply to this email directly or view it on GitHub https://github.com/robclancy/presenter/pull/43#issuecomment-83159291.

impleri commented 9 years ago

Poking the beehive...

barryvanveen commented 9 years ago

@robclancy, is there a plan for supporting Laravel 5.1 in the near future?

If I could assist in any way, please let me know.

otherguy commented 8 years ago

Poke :)

robclancy commented 8 years ago

No one has actually told me what doesn't work, I have used this recently in a 5.x project. I am looking to start a new project where I use it more as using it makes it far easier for me to know what it needs etc.