robconery / troys-book

A repository for feedback on Troy Hunt's book.
2 stars 0 forks source link

comma after a closing bracket #56

Closed mrutgers closed 1 year ago

mrutgers commented 1 year ago

pdf version 001, on several pages, reading with Edge on Windows 11

You only need a comma after a closing bracket if the sentence would contain one anyway. Here are the instances where I believe the comma after the closing bracket is not needed:

page 35 - one that is as long and as random (in terms of both character types and sequence), as possible page 43 - Here's how some people (Google, in this case), believe you should create page 53 - Certainly what we'd call a zero-day vulnerability (one that is not yet known), is possible page 84 - The positive feedback of the service explicitly returning the number plate (and degree of confidence in its integrity), is gone page 115 - to see if your email address (and consequently your password), was leaked page 232 - Sometimes (such as with the realestate.com.au vulnerability I reported last year), this is all that’s required. page 242 - Compare that Zoosk data (I'll refer to it as "Zoosk data" even though ultimately I disprove this), to this one page 266 - The irony of some of the abuse I get (and certainly some people do get very angry about my affiliations), is that page 388 - either in full (I've never passed a breach to anyone else), or in part page 580 - Where it gets interesting (and this is the whole point of the post), is when page 649 - Take mining out of the picture and the top industry ("Consulting & Strategy"), pays only 5% more page 684 - These issues (among others), led the council's Director of Digital Policy to conclude page 722 - She's now at the local court whilst I (in my helicopter parent mode), am sitting at home page 733 - in many cases, (such as the photos older kids are often taking), very sensitive.

troyhunt commented 1 year ago

Firstly, we appreciate all the feedback, thank you 🙏

Had a meeting with @robconery and @CharlotteLyng this morning and we discussed the level of edits we'd take onboard. Typos and incorrect words are definitely in scope, but we're going to avoid minor grammatical issues like these where possible. But FWIW, I usually only added commas after brackets when Word prompted me to do so. I suspect that isn't always correct, but it's minor enough not to justify investing effort modifying now.

mrutgers commented 1 year ago

Fair enough Troy. I had been wondering anyway where you would have to draw the line. I am enjoying the book very much. Quite often I intend to read for a short while at the end of the day, and then find myself still reading half an hour later...

------ Original Message ------ From: "Troy Hunt" @.> To: "robconery/troys-book" @.> Cc: "mrutgers" @.>; "Author" @.> Sent: Thursday, 6 Oct, 2022 At 06:51 Subject: Re: [robconery/troys-book] comma after a closing bracket (Issue

56)

Firstly, we appreciate all the feedback, thank you 🙏 Had a meeting with @robconery https://github.com/robconery and @CharlotteLyng https://github.com/CharlotteLyng this morning and we discussed the level of edits we'd take onboard. Typos and incorrect words are definitely in scope, but we're going to avoid minor grammatical issues like these where possible. But FWIW, I usually only added commas after brackets when Word prompted me to do so. I suspect that isn't always correct, but it's minor enough not to justify investing effort modifying now. — Reply to this email directly, view it on GitHub https://github.com/robconery/troys-book/issues/56#issuecomment-1269361985 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AD3OL4SY4UTICJO43W3DNKDWBZSHFANCNFSM6AAAAAAQ5RIFTQ . You are receiving this because you authored the thread.Message ID: @.***>