robcowie / SublimeTODO

**[DEPRECATED]** - See https://github.com/jonathandelgado/SublimeTodoReview - Extract TODO-type comments from open files and project folders
295 stars 54 forks source link

Set tab title #7

Closed kgrossjo closed 12 years ago

kgrossjo commented 12 years ago

I think the tab created by the "show todos" command should not be named "untitled". It should be named "TO DO" or "ACTIONS" or maybe "* TODO *".

robcowie commented 12 years ago

This one's easy. I'll add a setting result_title (defaulting to 'TODO Results') and append a number to differentiate between existing results pages (TODO Results 1, TODO Results 2 etc.). User can override the title if they want.

kgrossjo commented 12 years ago

I wonder why there is the suffix? Is it to support multiple projects? I think the user can only have one project open per window at a time, so one "TODO Results" per window should be fine, as well?

There must be something I'm not seeing...

robcowie commented 12 years ago

I didn't like the idea of destroying an existing TODO list with a new one. The user may have edited it for example. However, I think I'm probably imagining scenarios that don't really exist. It would certainly be simpler to assume only one TODO list per window.

kgrossjo commented 12 years ago

What would happen if the user saved the to do list? I think that might change the tab title. And then the next to do command would automatically create a new tab, if the implementation looks at the name...

robcowie commented 12 years ago

I'm undecided on what should happen in that case:

a) Don't overwrite the saved view, instead create a new view b) Replace the contents of the saved view and set is_dirty = True

Both are fairly trivial to implement. Your thoughts are appreciated.

kgrossjo commented 12 years ago

I proposed this as a solution for the user to allow editing a to do list without these edits getting clobbered by another invocation of "compute to do items".

So:

And:

I'm not sure whether this is a good idea. Just wanted to clarify what I was thinking.

robcowie commented 12 years ago

I agree not clobbering user edits in a results view is a good idea. So;

Good for you?

kgrossjo commented 12 years ago

Purr-fect!