search

robcresswell / vue-material-design-icons

Material Design Icons as Vue Single File Components
https://npmjs.com/vue-material-design-icons
MIT License
162 stars 35 forks source link

Remove title when purely decorative. #260

Closed scoxatpush closed 3 years ago

scoxatpush commented 3 years ago

Addresses issue #115 with the trivial suggestion (remove title element when decorative flag is set)

robcresswell commented 3 years ago

This seems good to me. Would you mind updating the commit message to follow semantic release guidelines?

feat: remove title when purely decorative
scoxatpush commented 3 years ago

My apologies; I was in a rush.

scoxatpush commented 3 years ago

The more I think about this, the less I like it. It's probably going to break somebody's use case in a counter-intuitive way, for example if they've explicitly set the title prop.

robcresswell commented 3 years ago

Do we care if someone has explicitly set a title when the icon is decorative only? Not sure that's a valid use case

I'm tempted to merge this, and release it alongside Vue 3 support as a possibly breaking change

scoxatpush commented 3 years ago

Any updates on those plans @robcresswell ?

robcresswell commented 3 years ago

Hey @scoxatpush I pushed your commit as part of #264. I wanted to update the commit message so semver tags it as a bugfix, but it felt rude asking after so many months. Thanks for your fix!