feat: Vue 3 compatibility & better a11y

robcresswell / vue-material-design-icons

Material Design Icons as Vue Single File Components

https://npmjs.com/vue-material-design-icons

MIT License

162 stars 35 forks source link

feat: Vue 3 compatibility & better a11y #270

Closed robcresswell closed 2 years ago

robcresswell commented 3 years ago

BREAKING CHANGE: This PR reverts the changes to make these components functional, making them usable in both Vue 2 and Vue 3. If you're using loads of icons on one page, you may see minor performance regressions in Vue 2.

This patch also removes the default title, encouraging better accessibility by removing unhelpful titles that dont indicate usage. The decorative prop has been removed and any icons that do not have a meaningful title will be hidden from screen readers.

Oldenborg commented 2 years ago

@robcresswell do you need any help with this? is there something I can do to get take this across the finish line? This project has 19k weekly downloads. And that number keeps growing.