[Vue 3] click event fires twice

[ibrahim-sakr]

when using Vue 3 and because Vue 3 changed the way that events passed to a component. see Fallthrough Doc

you will face a click event fires twice when you use it like this <menu-icon @click="someFunc" /> in this case, someFunc will always run twice

the reason for this is the @click in the lib components definitions.

for Vue 3 this @click here <span @click="$emit('click', $event)"> should be removed and Vue will handle the events automatically or perhaps the attribute inheritAttrs: false should be used instead for the compatibility with Vue 2

[robcresswell]

Oh nice catch, thanks for this. I'll take a look at the weekend and decide on a solution

[robcresswell]

This was fixed by https://github.com/robcresswell/vue-material-design-icons/commit/2f08947dbf7d23df5a38f21491651da3d5f9ceea but I forgot to close it. Thanks!