robcresswell / vue-material-design-icons

Material Design Icons as Vue Single File Components
https://npmjs.com/vue-material-design-icons
MIT License
162 stars 35 forks source link

Prevent double clicking #277

Closed 1VinceP closed 2 years ago

1VinceP commented 2 years ago

In Vue 3, click events fall through meaning each event is fired twice when adding @click prop to the component. Adding emits: ['click'] tells the component to expect an external click event, therefore preventing the double event. See here for more details

gtjamesa commented 2 years ago

@robcresswell can you merge this and publish a release?

robcresswell commented 2 years ago

Hello, merged #282; I marked you as a co-author @1VinceP. I made the other PR so I could make the commits play nice with semantic-release. Didn't want to ask you to update the PR so many months later. Hope thats okay. Thanks for the fix!