robdimarco / omniauth_crowd

An OmniAuth provider for Atlassian Crowd REST API
MIT License
30 stars 21 forks source link

Remove use_sso? method from configuration #29

Closed natlibfi-arlehiko closed 8 years ago

natlibfi-arlehiko commented 8 years ago

Remove OmniAuth::Strategies::Crowd::Configuration.use_sso? method. It's not needed because we already have use_sessions? and it was used incorrectly anyway (use_sso? checked for existence of sso_url and was used when the URL was not even needed).

This is a bug fix and probably a major level change since it's changes (Once again) how sessions are used. Sorry I didn't notice this earlier!