search

robdodson / Atom-PolymerSnippets

Atom snippets for Polymer and Web Components
MIT License
81 stars 24 forks source link

Test Snippets #30

Closed BLamy closed 8 years ago

BLamy commented 8 years ago

Both BDD and TDD sort of like the polymer generator.

https://github.com/yeoman/generator-polymer/blob/master/el/templates/test/tdd.html

https://github.com/yeoman/generator-polymer/blob/master/el/templates/test/bdd.html

mateusortiz commented 8 years ago

Good tip, it was as expected?

robdodson commented 8 years ago

@BLamy hm do you think this could be covered by a separate Mocha package?

mateusortiz commented 8 years ago

@robdodson This looks good

robdodson commented 8 years ago

Oh I didn't realize this was being commited. @mateusortiz would you mind opening a pull request for future changes so we can discuss them?

mateusortiz commented 8 years ago

Yeap of course. Sorry!

BLamy commented 8 years ago

Can we change the shortcut for it from *-element to bdd-test and tdd-test.

The snippets aren't really 'elements'. I doubt it will make a difference as far as typing goes since most people will have hit tab before they get to that part.

robdodson commented 8 years ago

sure! I think there's also a couple spots where we can remove the scripts for test-fixture because (I believe) that just comes with web component tester now and doens't need a specific script/import

On Tue, Feb 2, 2016 at 2:49 PM, BLamy notifications@github.com wrote:

Any chance the shortcut for it can be changes to bdd-test and tdd-test instead of *-element.

The snippets aren't really 'elements'. I doubt it will make a difference as far as typing goes since most people will have hit tab before they get to that part.

— Reply to this email directly or view it on GitHub https://github.com/robdodson/Atom-PolymerSnippets/issues/30#issuecomment-178872612 .

TimvdLippe commented 8 years ago

This issue was fixed in https://github.com/robdodson/Atom-PolymerSnippets/commit/685bc68de6393da8a76a110e390f486f5dcb655e and can be closed