roberodin / ha-samsungtv-custom

📺 HomeAssistant - SamsungTV Custom Component
Apache License 2.0
122 stars 177 forks source link

New ideas #4

Closed escoand closed 4 years ago

escoand commented 4 years ago

Hi @roberodin.

I would be interested in working together with you to get this integration to another level. I've already started multiple attempts (the last) to do this but get stuck by the not supported samsungctl library. For me it seems to be the game changer to get the fork from kdschlosser to PyPi. When somebody is willing to do this we have done a big step further.

Additionally for my old TV UE40ES5700 (legacy protocol) the connection is very limited as it is only an smart IR remote. You are only able to send key codes but not more. Don't know what with the websocket protocol is doable. Therefore I investigated the also existing UPNP interface. With this I was able to get much more power than the current samsungctl could give.

I'm now somehow familiar with all the config_flow thing and could implement this if you're interested. Also I could extend here and there in your custom component as I did this in my attempts as well.

What do you thing to all this?

1DontEx1st commented 4 years ago

Just curious - have you considered having these changes implemented in the official component?

escoand commented 4 years ago

Not yet, I tried as you can see in the link above. But I need to split it in smaller ones. But one time you always come to the point that we need the newer fork from kdschlosser which is not at PyPi.

dolenec commented 4 years ago

Maybe to add HTTP post commands for opening applications: https://www.panbachi.de/samsung-tv-app-starten-ueber-http/

For me this is working (using YouTube and Netflix).

escoand commented 4 years ago

@dolenec It's not desired to have protocol specific things in the integrations. That was also a point why my upnp integration was denied.

roberodin commented 4 years ago

I am quite disappointed with Samsung TVs specifically with the tizenOS operating system, the best solution to all this is to buy something with Android TV!

roberodin commented 4 years ago

@escoand I added several protocols or versions to the component to cover more models, if you want to add some more do a PR and package it all

escoand commented 4 years ago

@roberodin what do you think about upstreaming your work?