search

robert-harbison / xterm-for-react

A React wrapper made for XTerm.js
MIT License
114 stars 50 forks source link

Support For React18, Updated Dependencies #24

Open jaxtonw opened 1 year ago

jaxtonw commented 1 year ago

Updated the project and all it's dependencies to build again and support React 18. Previous packages were deprecated and the project in it's current state did not build. This has since been fixed, and with updated dependencies, it should hopefully last for a while.

The version has been updated to 1.1.0. I debated versioning to 2.0.0, but this shouldn't cause any major breaking changes for React 16/17 to my knowledge.

I apologize if any of the configuration changes when updating dependencies conflict with the initial plans of the project. I struggled a bit in trying to keep things as similar as similar as possible while not being able to build the old version.

Any critiques or suggestions are appreciated!

jaxtonw commented 1 year ago

The previous commits from when this PR was opened did not actually work with TypeScript. This issue stems from webpack. Just compiling the project with tsc caused everything to work properly, and also resulted in a smaller distribution. The previous two commits accomplish that.

jaxtonw commented 1 year ago

@robert-harbison has there been any updates on this pull request?

jaxtonw commented 1 year ago

@robert-harbison have you had a chance to look at this yet? People are starting to suggest name-squatting packages in order to fulfill what this PR attempts to accomplish.

https://github.com/robert-harbison/xterm-for-react/issues/22#issuecomment-1566174032

JensvandeWiel commented 1 year ago

@robert-harbison please take a look at this and update it.

kylebonnici commented 1 year ago

@robert-harbison any plans to merge this ?

I have just tried this out by building local and it works :) nice work @jaxtonw.

JensvandeWiel commented 1 year ago

Someone should make a good fork and maintain it :/

PabloLION commented 4 months ago

Hi @jaxtonw, I made a new repo (with react18 support) for the same purpose on https://github.com/PabloLION/xterm-react and I'm trying to improve it. I like the tests you've written. Would you mind to make a similar PR in my repo, or if I copy them from this PR directly? Thanks for the hard work to the open source community!

P.S. I have an end-to-end test with vite, and I'm planning to host it with GitHub Pages as a live example. You might want to consider how to integrate the test with that as well