robert-hh / ads1x15

Micropython driver for ADS1115 and ADS1015
90 stars 25 forks source link

ads1015 #2

Closed acopernic closed 6 years ago

acopernic commented 6 years ago

Hello, for the ads1015 i have a problem with your driver. I had to delete the gain on this ads = ads1x15.ADS1015(i2c, addr) by adding the gain i have this issue function takes 4 positional arguments but 5 were given

robert-hh commented 6 years ago

Thanks for the note. I'll take a look at it.

robert-hh commented 6 years ago

Try to change the beginning of the ADS1015 class to:

class ADS1015(ADS1115):
    def __init__(self, i2c, address=0x48, gain=1):
        super().__init__(i2c, address, gain)

That adds the missing gain parameter.

robert-hh commented 6 years ago

Added the missing parameter to the ADS1015 class in commit a819b84

acopernic commented 6 years ago

Thanks. Done and working. The gain is quite useful.

Thank you. On 24 Jun 2018, at 19:13, robert-hh notifications@github.com<mailto:notifications@github.com> wrote:

Try to change the beginning of the ADS1015 class to:

class ADS1015(ADS1115): def init(self, i2c, address=0x48, gain=1): super().init(i2c, address, gain)

That adds the missing gain parameter.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/robert-hh/ads1x15/issues/2#issuecomment-399771985, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ASJYj8buemT7VlF2fWtWnWZBvtUPK4Kzks5t_8jFgaJpZM4U1Nub.