robert388 / Necrosis-classic

Necrosis addon wow classic
25 stars 14 forks source link

Soulstone doesnt create one #124

Closed ghost closed 4 years ago

ghost commented 4 years ago

Its random. Sometimes it creates a soulstone, sometimes it doesnt. I need to open the spellbook. Adding features is nice but breaking the addon with every update is not

ghost commented 4 years ago

~~I got some more feedback on this. This behavior is 100% reproducable. It happens if you bind a macro to cast sousltone and then try to create a new one from the addon. For example i use a macro to cast soulstone on raids because i have my own custom output text. If i don't cast soul ressurection with necrosis and use my macro, the next time i click on necrosis soulstone button to create one nothing happens. I need to relog to solve it.~~

Edit: After update it is reproducable if you have no target. U need to have a target to create a soulstone

DevineLykan commented 4 years ago

can confirm this issue, looks like in necrosis.lua it's treating the soulstone action the same as when creating one, there is no differentiation in the code for the two events as it was before the recode.

ghost commented 4 years ago

This happened on a older update as well and took some time to fix, i hope we get the fix soon

DevineLykan commented 4 years ago

Fixed in latest version, you can close this issue.