robert388 / Necrosis-classic

Necrosis addon wow classic
25 stars 14 forks source link

Feature Request: Disable addon when logged on other classes #133

Open byeuji opened 4 years ago

byeuji commented 4 years ago

Hi all, Apologies if this is a repeat request. I looked through the issues tracker and didn't find anything related to this. I have several characters that I regularly play that are not warlocks. I'm wondering if this addon could hide itself and disable its triggers when the active character (self) is not a warlock? Currently, I need to enable and disable the addon each time, and due to a recurring lua error which I'm sure is detailed here already, it sometimes take multiple UI reloads to get Necrosis to load after being disabled.

I appreciate any thoughts!

byeuji commented 4 years ago

Experiencing this more, I think the real problem here is a LUA error I'm getting for the mod regardless of which character I'm on. The same is true as I said before that a /rl works to fix the error when I'm on my warlock, and it seems dismissing the error on other characters works as well. But it would be good to resolve the error entirely. There are 3 LUA errors which occur login:

Message: Frame NecrosisTooltip: Unknown script element OnTooltipSetDefaultAnchor
Time: Thu May 28 13:47:59 2020
Count: 1

Message: Frame NecrosisTooltip: Unknown script element OnTooltipAddMoney
Time: Thu May 28 13:47:59 2020
Count: 1

Message: Frame NecrosisTooltip: Unknown script element OnTooltipCleared
Time: Thu May 28 13:47:59 2020
Count: 1
weathondev commented 4 years ago

Why don't you just enable it for your warlock? You can choose for which character you want an addon to be enabled.

byeuji commented 4 years ago

I have not been able to do that. When I disable it for one, it disables it for all my characters.

weathondev commented 4 years ago

You can easily do that in game (logged in with a character) . Before disabling/enabling just choose the character in the drop down at the top.

byeuji commented 4 years ago

I'll try that. Thanks.

I want to leave this open though, because of the LUA error that persists.