robert388 / Necrosis-classic

Necrosis addon wow classic
25 stars 14 forks source link

Soulshards not being automatically destroyed #31

Open tnekau opened 5 years ago

tnekau commented 5 years ago

I have a 16 slot soul bag with shards set to go there. I have Necrosis set to destroy anything above 16 and when the bag is full.

Upon reaching 16 shards in the bag I get a message from necrosis telling me the soul bag is full and further shards will be destroyed, but they are not destroyed and keep accumulating in the other bags until full.

danslo commented 5 years ago

This only sometimes happens to me, and it's solved by doing a /reload.

tnekau commented 5 years ago

A reload doesn't usually fix it for me(though it does sometimes). It's definitely related to the soul shard bag as if I unequip that it seems OK most of the time.

I've tried changing the options around - unselecting the "put in specific bag" option and delete when full, and just relying on the "no more than x", as well as the other way around.

I don't think it's related to any other addons as it still fails when Necrosis is the only addon running.

tnekau commented 5 years ago

Still not working reliably after latest update

danslo commented 5 years ago

Try resetting your wtf configs, it doesn't happen to me anymore on recent update.

On Wed, Sep 18, 2019, 04:57 tnekau notifications@github.com wrote:

Still not working reliably after latest update

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/robert388/Necrosis-classic/issues/31?email_source=notifications&email_token=AAFVR3OKSL7BG55VWATQZDTQKGKIZA5CNFSM4IUTTVY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD66UG3Y#issuecomment-532497263, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFVR3N7F3NTG76LYQ2OVWDQKGKIZANCNFSM4IUTTVYQ .

tnekau commented 5 years ago

Deleting WTF has helped, it mostly works however sometimes (usually on on login but sometimes just randomly) I receive the following LUA error and it all stops working:

Message: Interface\AddOns\Necrosis\Necrosis.lua:1961: attempt to concatenate a nil value Time: Sat Sep 21 00:26:48 2019 Count: 1 Stack: Interface\AddOns\Necrosis\Necrosis.lua:1961: attempt to concatenate a nil value Interface\AddOns\Necrosis\Necrosis.lua:1961: in function BagExplore' Interface\AddOns\Necrosis\Initialize.lua:151: in functionInitialize' Interface\AddOns\Necrosis\Necrosis.lua:355: in function `OnLoad'

Locals: self =

{ BindName = defined @Interface\AddOns\Necrosis\Bindings.lua:42 RezTimerUpdate = defined @Interface\AddOns\Necrosis\Timers\OtherTimers.lua:45 Unit =
{ } InsertTimerParTable = defined @Interface\AddOns\Necrosis\Timers\Functions.lua:46 ButtonSetup = defined @Interface\AddOns\Necrosis\Necrosis.lua:2034 Timer_Click = defined @Interface\AddOns\Necrosis\XML\Options-Timers.lua:194 Localize =
{ } SoulshardSwitch = defined @Interface\AddOns\Necrosis\Necrosis.lua:1970 FindSlot = defined @Interface\AddOns\Necrosis\Necrosis.lua:1996 Localization_Speech_Es = defined @Interface\AddOns\Necrosis\Speech\Speech-es.lua:37 BuffVector_Click = defined @Interface\AddOns\Necrosis\XML\Options-Menus.lua:792 Localization_Dialog_En = defined @Interface\AddOns\Necrosis\Locales\Dialog-en.lua:41 SetCompanionPage = defined @Interface\AddOns\Necrosis\XML\Options-Buttons.lua:551 CreateGroup = defined @Interface\AddOns\Necrosis\Timers\GraphicalTimers.lua:45 Localization_Dialog_De = defined @Interface\AddOns\Necrosis\Locales\Dialog-de.lua:41 Msg = defined @Interface\AddOns\Necrosis\Message.lua:42 AddFrame = defined @Interface\AddOns\Necrosis\Timers\GraphicalTimers.lua:114 HealthstoneCooldown = "Healthstone Cooldown" InCombatAttribute = defined @Interface\AddOns\Necrosis\XML\Attributes.lua:443 RetraitTimerParGuid = defined @Interface\AddOns\Necrosis\Timers\Functions.lua:313 OnLoad = defined @Interface\AddOns\Necrosis\Necrosis.lua:337 DemonVector_Init = defined @Interface\AddOns\Necrosis\XML\Options-Menus.lua:810 ShowAntiFearWarning = defined @Interface\AddOns\Necrosis\Necrosis.lua:2357 MenuAttribute = defined @Interface\AddOns\Necrosis\XML\Attributes.lua:47 CreateWarlockUI = defined @Interface\AddOns\Necrosis\XML\XML.lua:73 GetCompanionInfo = defined @Interface\AddOns\Necrosis\Necrosis.lua:2889 Event_Init = defined @Interface\AddOns\Necrosis\XML\Options-Sphere.lua:245 Speech_It = defined @Interface\AddOns\Necrosis\Message.lua:160 SetTimersConfig = defined @Interface\AddOns\Necrosis\XML\Options-Timers.lua:45 Event_Click = defined @Interface\AddOns\Necrosis\XML\Options-Sphere.lua:257 UnitHasBuff = defined @Interface\AddOns\Necrosis\Necrosis.lua:2338 Spell_Init = defined @Interface\AddOns\Necrosis\XML\Options-Sphere.lua:267 SetMenusConfig = defined @Interface\AddOns\Necrosis\XML\Options-Menus.lua:45 SetMessagesConfig = defined @Interface\AddOns\Necrosis\XML\Options-Messages.lua:45 StoneAttribute = defined @Interface\AddOns\Necrosis\XML\Attributes.lua:290 Spell_Click = defined @Interface\AddOns\Necrosis\XML\Options-Sphere.lua:278 UpdateHealth = defined @Interface\AddOns\Necrosis\Necrosis.lua:1437 Translation =
{ } RegisterManagement = defined @Interface\AddOns\Necrosis\Necrosis.lua:695 ChangeDemon = defined @Interface\AddOns\Necrosis\Necrosis.lua:711 Speech =
{ } Localization_Speech_Ru = defined @Interface\AddOns\Necrosis\Speech\Speech-ru.lua:38 CreateWarlockPopup = defined @Interface\AddOns\Necrosis\XML\XML.lua:417 MsgReplace = defined @Interface\AddOns\Necrosis\Message

danslo commented 5 years ago

I get this error too (on login), but a /reload fixes this for me.

Probably duplicate of https://github.com/robert388/Necrosis-classic/issues/42 and https://github.com/robert388/Necrosis-classic/issues/44.

tnekau commented 5 years ago

Yep, a /reload will generally fix it, however the inconsistent behavior regarding the deleting of soul shards is still persisting. I can't find any consistent way to make it fail, but generally speaking more often than not it does not work. Sometimes a reload will fix it, but more often than not it won't.

When shard management stops working most of the time it's silent (ie no LUA error, just stops deleting).

tnekau commented 5 years ago

LUA error still happening as of todays update. Almost every time on login.