search

robert7 / nixnote2

Nixnote - Evernote desktop client for Linux
GNU General Public License v3.0
297 stars 32 forks source link

Fixed the issue: Nixnote2 exits when network gets disconnected #189 #190

Closed boo-yee closed 2 years ago

boo-yee commented 2 years ago

The reason of issue #189 is: Nixnote will show a dialog when sync error happens. When closing the dialog, the whole application will exit. This is a Qt feature.

To fix this issue, I made the sync error dialog not show when the main window is minimized to the system tray. Instead, Nixnote will pop up sync error from the tray icon now.

Besides that, I did some improvements about font size setting.

In EditorButtonBar::loadFontSizeComboBox(), I replaced smoothSizes() with pointSizes(), because AppearancePreferences::loadFontSizes() uses this function to load font sizes too. And smoothSizes() and pointSizes() always return different results when the same font is passed in to them. Because of this, the font size lists in the editor and preference dialog differed previously.

And I also made a supplyment to pr #187. That is, I made the fontSizeSelected() be called even when the value in the combobox has no change, through connecting the activated signal instead of currentIndexChanged signal from buttonBar->fontSizes, with slot function fontSizeSelected(). This is useful when texts in different sizes are selected and the user intends to resize them to the current font size in the combobox.

robert7 commented 2 years ago

hi, thx, PR looks OK (I'll merge it later). could you pls send me your email? my email is nightingale7@gmail.com

i got request from one user about Windows binary, maybe you could forward the binary to him

andruska commented 2 years ago

Thanks for fixing this issue. Also I will test the font size issue after merging it to master.

boo-yee commented 2 years ago

hi, thx, PR looks OK (I'll merge it later). could you pls send me your email? my email is nightingale7@gmail.com

i got request from one user about Windows binary, maybe you could forward the binary to him

OK, sure. My email is booyee12@proton.me. I have uploaded a Windows binary to github, it can be downloaded here. This is the lastest build until now, not perfect yet perhaps. My speed of uploading to the email server is too slow, so I didn't send it via the email to you, you could let him download the binary from the link. And I'll attempt to extend the CI for Windows, so that other people can get the following updates, if any.

boo-yee commented 2 years ago

Thanks for fixing this issue. Also I will test the font size issue after merging it to master.

Glad to help you.

robert7 commented 2 years ago

perfect. thank you