search

robert7 / nixnote2

Nixnote - Evernote desktop client for Linux
GNU General Public License v3.0
297 stars 32 forks source link

AppImage file name must contain version number #201

Closed vitaly-zdanevich closed 1 year ago

vitaly-zdanevich commented 1 year ago

As a common practice, for usability.

And Gentoo cache based on the file name.

robert7 commented 1 year ago

how do you mean that? where do you expect the version number?

vitaly-zdanevich commented 1 year ago

Here https://github.com/robert7/nixnote2/releases/download/v2.1.8/NixNote2-x86_64.AppImage

Like NixNote2.8.2-x86_64.AppImage

robert7 commented 1 year ago

I did some googling, whenever there is some universal/best practice convention of naming release artefacts/assets, but actually did not find much.

So I guess it is a bit a matter of taste.

As all the previous releases use AppImage name with constant filename like NixNote2-x86_64.AppImage I leave it as it is for now. The version is actually in the URL: https://github.com/robert7/nixnote2/releases/download/v2.1.8/NixNote2-x86_64.AppImage.

Further the version is inside of the AppImage, you can see it in the About box (after starting the file). You can also unpack the AppLimage (./NixNote2-x86_64.AppImage --appimage-extract) and then find version in a text file in squashfs-root/usr/share/nixnote2/build-version.txt.

As the project is rather in "maintenance mode", than in really actiove development, I prefer not to change cosmetic things.

image

vitaly-zdanevich commented 1 year ago

About AppImage unpacking: is it a good for package managers? As I understand, after unpacking it will start faster?

robert7 commented 1 year ago

As I understand, after unpacking it will start faster?

The difference may be negligible, but I'm not an expert in this area. As far I know, the "packed" AppImage is mounted via FUSE file system. And normally it is quite fast.