search

robertIanClarkson / SFSU-Connect

A buy & sell website focused on San Francisco State University students and faculty. An excellent example of working in a team environment with a mock CEO, CTO, Milestones, and Deadlines.
https://robertianclarkson.github.io/SFSU-Connect/
MIT License
2 stars 2 forks source link

Fix color for the pages #209

Closed kefung2 closed 3 years ago

kefung2 commented 3 years ago

@taylorlukee in the login.css, you use the class ( .name ) instead of id ( #name) since robin ask us to use id before can you change that.

robertIanClarkson commented 3 years ago

@taylorlukee

So first off... It looks really good! way better than before. You are surely going to want to throw this project on your resume!

One thing that is wrong though... the footer you included the footer into views/components/navbar.pug which isn't right. The footer was already made before in the right format. all you needed to do was go to each page and include components/footer at the bottom of the content block. That way once you get to the bottom of the page the footer is there.

Two things to think about... rounded corners are a great easy way to keep things looking fresh and not too "1990s" boxy check it out. it is super easy https://www.w3schools.com/css/css3_borders.asp

padding is a great way to keep elements spaced nicely. For example, we surely need to pad the white forms in login and registration. https://www.w3schools.com/css/css_padding.asp