robertaboukhalil / ginkgo

Cloud-based single-cell copy-number variation analysis tool
qb.cshl.edu/ginkgo
BSD 2-Clause "Simplified" License
47 stars 28 forks source link

Issue #13: FACS file parsing breaking #14

Closed robertaboukhalil closed 5 years ago

robertaboukhalil commented 5 years ago

This PR is to address issue #13.

Initially, it seemed like the issue was that, given a FACS file, Ginkgo could only pick a CN multiplier within [1.5, 6], even though a cell was marked as e.g. ploidy 1.3. However, looking more closely at the code, the multiplier is correctly set by the FACS file regardless of its value.

So Ginkgo's CN calculation works fine; where it breaks is when it tries to plot the SoS error plot; this is where it assumes the CN multiplier is within [1.5, 6], so this PR updates that SoS plot such that it shows:

cc: @jpritt: I sent you an invite to become a collaborator on this repo so that I can add you as a reviewer


Sample output (with FACS file):

Sample output (without FACS file):

(hg19.T1 is the cell that currently fails in Ginkgo)

mschatz commented 5 years ago

Looks great. Thanks for working on this!

Mike

robertaboukhalil commented 5 years ago

Thanks Mike! Is this deployed to qb.cshl.edu?

andrewrlynch commented 5 years ago

Hi all, Thank you all for being so responsive and working on this. I've tried running these files again with the FACS file and have been getting the same errors I described earlier. Have these changes been deployed?

Thanks again, Andrew