search

robertbasic / pugdebug

pugdebug is a standalone debugging client for PHP applications that uses XDebug as the debugging engine.
http://pugdebug.com/
Other
73 stars 15 forks source link

Listing breakpoints in a for loop #200

Closed robertbasic closed 7 years ago

robertbasic commented 7 years ago

The list_breakpoints method on the debugger gets called in a for loop: https://github.com/robertbasic/pugdebug/blob/22b2baede5d34b7949b83d254eab0210d7c3ee7d/pugdebug/pugdebug.py#L785

Investigate is that on purpose or just an indentation error.

The entire handle_breakpoint_removed is smelly a little bit.

robertbasic commented 7 years ago

Never mind, it's on purpose. It gets called maybe only once in the loop, when the breakpoint being removed is same as one of the breakpoints we have set.