search

robertdebock / ansible-role-fail2ban

Install and configure fail2ban on your system.
https://robertdebock.nl/
Apache License 2.0
62 stars 29 forks source link

Add modifiable configuration vars #3

Closed j8r closed 5 years ago

j8r commented 5 years ago

name: Add modifiable configuration vars about: Be able to customize the Fail2ban configurations

Describe the change Before, it was impossible to customize the configurations without having to override fail2ban_configuration and fail2ban_jail_configuration present in vars.yml, which isn't ideal.

Now, this variables are in default.yml, which are concatenated to fail2ban_base_configuration and fail2ban_base_jail_configuration. Testing We have deployed this branch in our bastion.

robertdebock commented 5 years ago

Looks like a very logical change, thanks a lot! I'll wait for CI to test the change, could take a day or so. (I've pushed many changes in yesterday.)

Tahnks @j8r!

j8r commented 5 years ago

@robertdebock CI pass on most platforms. The issues related to Alpine (logger) and Amazon Linux (package missing) are unrelated, and already in master.

robertdebock commented 5 years ago

Hi @j8r, you are correct. I'll merge and fix the build issues a little later.

Once again, thanks!