robertdebock / ansible-role-fail2ban

Install and configure fail2ban on your system.
https://robertdebock.nl/
Apache License 2.0
59 stars 29 forks source link

Fix assert test fail2ban_configuration and fail2ban_jail_configuration #6

Closed rgevaert closed 4 years ago

rgevaert commented 4 years ago

Adding extra config isn't possible because the assert fails with:

TASK [robertdebock.fail2ban : test if fail2ban_jail_configuration is set correctly] *** fatal: [gepdata-dev]: FAILED! => { "assertion": "item.option is defined", "changed": false, "evaluated_to": false, "msg": "Assertion failed" }

Adding the loop fixes it as we now test the elements of the passed list

robertdebock commented 4 years ago

Thanks! Weird that the loop was missing. Thanks @rgevaert!

Regards,

Robert de Bock.

rgevaert commented 4 years ago

Thanks for the quick approval! Also learned something new: how to reduce that loop output.