robertdebock / ansible-role-rsyslog

Install and configure rsyslog on your system.
https://robertdebock.nl/
Apache License 2.0
37 stars 40 forks source link

Add option PreserveFQDN on advanced_rsyslog.conf #18

Closed OliPou closed 3 years ago

OliPou commented 3 years ago

name: Pull request about: Describe the proposed change


Describe the change A clear and concise description of what the pull request is.

Testing In case a feature was added, how were tests performed?

robertdebock commented 3 years ago

Hi,

That's a good feature.

May I ask for a few changes:

So in this case, the variable would become: rsyslog_preservefqdn.

I'll write the assertions in tasks/assert.yml if they are missing. I'll also update the documentation once done.

Once again, thanks for helping, much appreciated!

OliPou commented 3 years ago

Hi @robertdebock ,

I just modified my varaible for rsyslog_preservefqdn. I add a new section in tasks/assert.yml for my varaible rsyslog_preservefqdn and I also fill up the readme. Let me know if you need anything else.

Regards,

robertdebock commented 3 years ago

Great, looks good. Let's wait for CI to pass. Thanks!