search

robertdebock / ansible-role-rsyslog

Install and configure rsyslog on your system.
https://robertdebock.nl/
Apache License 2.0
36 stars 40 forks source link

Move include conf at the end #22

Closed smutel closed 3 years ago

smutel commented 3 years ago

name: Pull request about: Move include conf at the end

Describe the change It seems that rsyslogd is reading configuration line by line so if the include conf is done too early we encountered some error messages

Testing Role deployed

robertdebock commented 3 years ago

That looks good, thanks for helping!

May I suggest to make pull/merge-requests smaller? I prefer many small PRs over one PR with many changes. It makes reviewing easier. But, thanks anyway for you contribution!

smutel commented 3 years ago

That looks good, thanks for helping!

May I suggest to make pull/merge-requests smaller? I prefer many small PRs over one PR with many changes. It makes reviewing easier. But, thanks anyway for you contribution!

Sorry for that. I got the config file installed by the rsyslog debian package and I updated a little bit the comments and the order in the file.