search

robertdebock / ansible-role-tomcat

Install and configure tomcat on your system.
https://robertdebock.nl/
Apache License 2.0
46 stars 57 forks source link

tomcat.service improvements #16

Closed DuffMck closed 5 years ago

DuffMck commented 5 years ago

name: Improve tomcat.service about: Changed tomcat.service.j2 template following the tutorial of DigitalOcean

Describe the change Changed the template tomcat.service.j2

Testing Tested on Ubuntu18.04

robertdebock commented 5 years ago

Hi,

Thanks for the contribution.

This services are configured using another role, you can see that here: https://github.com/robertdebock/ansible-role-tomcat/blob/master/tasks/instance.yml#L63

So; if you need to have a different template, the ansible-role-service is the correct role to contribute to. Be aware that the service role is generic, so all modifications would need to keep on working for other roles that depend on the service role.

Anyway, thanks for the input, even though I'm going to close this pull request.