search

robertdebock / ansible-role-tomcat

Install and configure tomcat on your system.
https://robertdebock.nl/
Apache License 2.0
46 stars 57 forks source link

Add s3 support #4

Closed rgooler closed 5 years ago

rgooler commented 6 years ago

Since s3 support is available in ansible, and its a semi-common way to store archived files like .wars, I figured s3 support would be a good thing. And it keeps me from having to maintain a fork. :)

Tested and working. Also had some issues with installing on ubuntu, as the directories for wars were not created properly.

robertdebock commented 6 years ago

I agree that support for s3 is a great plan. Let me review your code and probably ask for a few questions.

rgooler commented 6 years ago

Currently seems to not be starting my app up locally - figuring out why it seems to be installing the sample app instead of the one I gave it.

rgooler commented 6 years ago

This is failing on ansible 2.3 and I don't understand why. Fixed the rest of the tests, though.

rgooler commented 6 years ago

Ok, now everything works - optionally clears out tomcat and runs JUST the war you choose hosted at / if you only pass in one war file to be installed, and allows you to add users and roles to tomcat-users.xml

Only thing that doesnt work is ansible 2.3, and that appears to be because 2.3 doesn't support using "when:" on actions.

robertdebock commented 5 years ago

Closing this request, because of conflict in merging and s3 can also be supported using the (existing) url structure:

---
tomcat_instances:
  - name: "{{ tomcat_name }}"
    url:
      - https://example.com/some.war