search

robertdebock / ansible-role-tomcat

Install and configure tomcat on your system.
https://robertdebock.nl/
Apache License 2.0
46 stars 57 forks source link

Feature: Make AJP Connector optional #40

Closed arnemoor closed 3 years ago

arnemoor commented 3 years ago

name: Pull request about: Make the AJP Connector optional

Describe the change Added two new flags that allow to disable AJP connector on global or instance level.

Testing Changes were tested in our local environment

robertdebock commented 3 years ago

Looks good, can you elaborate a bit more on the negative value for ports? I'm sure you're more aware what that does.

The failures in CI can be fixed by me later. Don't worry.

robertdebock commented 3 years ago

I'll fix the includes, the reason why CI is failing.

arnemoor commented 3 years ago

Thanks for including! The negative value for the ports is an alternative and more "visible" way to disable a connector. Instead of removing the configuration it's also possible to set the port to -1 which will disable the connector, instead of not loading it. So the difference is the startup of tomcat: Config block removed: connector is not loaded Config block their, port is -1: connector is loaded, but then disabled