search

robertdebock / ansible-role-tomcat

Install and configure tomcat on your system.
https://robertdebock.nl/
Apache License 2.0
46 stars 57 forks source link

Move tomcat subfolder folder in a specified one after unarchive #9

Closed DuffMck closed 5 years ago

DuffMck commented 5 years ago

If you install multiple instances of same tomcat version, now you have to specify different directories for each of them and in the folder you still have an unfriendly name like apache-tomcat-9.0.14. In addition, these kind of name are uncomfortable to manage with a deploy Ansible script.

It'll be nice if you can use the instance.name or specify something like instance.folder_name in order to have a file system like: opt\

In alternative using different instance.directory but specify a symbolic link in a specified position.

Thanks!

robertdebock commented 5 years ago

I'm going to look into this, thanks for your feedback!

It may take a couple of iterations and I may ask your for some more details.

Regards, Robert de Bock.

robertdebock commented 5 years ago

Indeed that was a very silly design, I've changed the way this role deploys tomcats.

For example these variables:

tomcat_instances:
  - name: "tomcat"
  - name: "tomcat-version-7"
    version: 7
    shutdown_port: 8007
    non_ssl_connector_port: 8082
    ssl_connector_port: 8445
    ajp_port: 8011

Now creates:

/opt/tomcat/${version}/bin/...
/opt/tomcat-version-7/${version}/bin/...

that ${version} is something I'll try to remove so you would end up with:

/opt/tomcat/bin/...
/opt/tomcat-version-7/bin/...

Great feedback @DuffMck! Would you be able to review this role once I've changed and released this feature/bug?

Regards,

Robert de Bock.

robertdebock commented 5 years ago

I'm going to close the issue, I think it's solved by the latest release, please let me know if you'd like the role to behave differently.

DuffMck commented 5 years ago

Sorry for the late of my reply. It looks good, I'll get a try this evening!

robertdebock commented 5 years ago

Cool, let me know when something work unexpected.