robertdebock / ansible-role-users

The purpose of this role is to add users and groups on your system.

https://robertdebock.nl/

Apache License 2.0

43 stars 27 forks source link

Error in "Ensure the sudoers.d directory is checked..." ? #30

Closed luri-fr closed 1 year ago

luri-fr commented 1 year ago

Describe the bug

Hi, Ty for you're hard work.

I'm read you're code and, perhaps they have an mistake in tasks/user.yml near line 55 :

- name: user | Ensure the sudoers.d directory is checked for user sudoers files (will be put after EOF if not exists)
  ansible.builtin.lineinfile:
    path: /etc/sudoers
    state: present
    line: "#includedir /etc/sudoers.d"

is a comment, no ?

In my /etc/sudoers file on an debian 11, i have @includedir /etc/sudoers.d

is this an mistake or not ?

robertdebock commented 1 year ago

I think both work, see here.

But; it looks like @includedir is the newer way to include. I also think #includedir is very confusing, so I'll change to @includedir.

Thanks for the issue!

robertdebock commented 1 year ago

This one is fixed, forgot to close the issue.