The module now required the variable vault_aws_certificate_arn to be set. To make a vault_aws_certificate_arn, the examples/*/main.tf create a few resources.
The resource vault_aws_certificate_arn is somewhat difficult to explain, whereas vault_hostname seems much more understandable.
Proposal:
Make vault_aws_certificate_arn optional. (default = "")
Introduce a new variable vault_hostname (or so).
Include these resources in the module: aws_acm_certificate, data: aws_route53_zone, aws_route53_record and aws_route53_record.
If a vault_aws_certificate_arn is provided, simply use it in the module. If vault_aws_certificate_arn is not provided, create the required resources.
The module now required the variable
vault_aws_certificate_arn
to be set. To make avault_aws_certificate_arn
, theexamples/*/main.tf
create a few resources.The resource
vault_aws_certificate_arn
is somewhat difficult to explain, whereasvault_hostname
seems much more understandable.Proposal:
vault_aws_certificate_arn
optional. (default = ""
)vault_hostname
(or so).aws_acm_certificate
, data:aws_route53_zone
,aws_route53_record
andaws_route53_record
.If a
vault_aws_certificate_arn
is provided, simply use it in the module. Ifvault_aws_certificate_arn
is not provided, create the required resources.