robertdebock / terraform-aws-vault

HashiCorp Vault on AWS
Apache License 2.0
25 stars 23 forks source link

Simplify deployment; Use `vault_hostname` instead of `vault_aws_certificate_arn` #78

Open robertdebock opened 1 year ago

robertdebock commented 1 year ago

The module now required the variable vault_aws_certificate_arn to be set. To make a vault_aws_certificate_arn, the examples/*/main.tf create a few resources.

The resource vault_aws_certificate_arn is somewhat difficult to explain, whereas vault_hostname seems much more understandable.

Proposal:

If a vault_aws_certificate_arn is provided, simply use it in the module. If vault_aws_certificate_arn is not provided, create the required resources.

robertdebock commented 1 year ago

Still relevant; either

This would require a major version release.