Closed robertdfrench closed 3 years ago
@calebwherry I think you actually have to leave a review on this one. It's marked as auto-merge, but it's still blocked waiting on a review from you which does not contain any unresolved conversations.
Oh! Or maybe you are waiting on review from me since you pushed last? I can't tell from this interface.
I was messing around in the app interface. I haven't reviewed it yet fully, too much to do on the app. My last push was the button to "get up to date with trunk" in the app, so I pushed it.
Ah okay, good deal. Take your time, I'm getting some things done in parallel.
This pr builds out the
git-pr-create
command. I took a few big deviations from our previous discussions which I should call out:git pr-create
impliesgit push
, we need to know the name of a remote that will receive the pushed objects. I decided to punt on solving this and go with "origin".fake_git
still doesn't do a lot, but it's now much more convoluted. I think what is there works... but perhaps we should switch to clap.Git::push_upstream
(git push -u) because I wasn't sure how to tackle thatIf you aren't comfortable punting on these, then we can address them before merging, but I think they'll each require a bit of brainstorming.