roberthovhannisyan / PhoneGap-Plugin-ListPicker

ListPicker Plugin for Cordova/PhoneGap (iOS and Android)
MIT License
35 stars 40 forks source link

Android: Radio-Buttons and Dialog #8

Open ma-pe opened 8 years ago

ma-pe commented 8 years ago

Hey, first of all: really nice work - thanks a lot. :)

Nevertheless I have a single suggestion: I think, that the usability of the ListPicker on Android is a little inconsistent. Normally (as you know it from the web) Radio-Buttons are used with an submit button, like the doneButton you are actually suggesting. On Android instead klicking a list-item is not only checking it, but also choosing it.

Therefore in my opinion there are two, slightly more consistent alternatives: 1) Use Radio-Buttons and Provide the done- and cancel-Button as well. 2) Just don't show Radio-Buttons (like in this screenshot: https://github.com/kidino/phonegap-alertdialoglist-plugin)

I would prefer Option 2) - But then you have to think about how to highlight the default-option ;)

roberthovhannisyan commented 8 years ago

Hi @ma-pe,

The idea behind the implementation was to get something similar to dialog which is displayed by browsers for html select element. It looks exactly the same (with radio buttons) and tapping the item results in selecting and closing the dialog.

Main reason for the implementation was the difficulty with displaying and using html select element in our js framework (Sencha Touch), because there was no such built in mechanism.

However, your ideas are worth trying (although cannot promise any timeframe - sorry for that).