robertjanetzko / LegendsBrowser

Legends Browser is an multi-platform, open source, java-based legends viewer for dwarf fortress 0.42.
MIT License
63 stars 19 forks source link

.dmg file fails to open #25

Closed thecodewarrior closed 6 years ago

thecodewarrior commented 6 years ago

When trying to open the .dmg release I am getting an error saying there are no mountable file systems. I've worked out that the issue turned up somewhere between the 1.13 and 1.14 releases. If you don't have a mac I'd be happy to test .dmg files for you.

untitled

robertjanetzko commented 6 years ago

I have. and I can open the .dmg I created as well as the ones downloaded from github and DFFD. Did you validate the checksum of your download with the one shown on DFFD?

lethosor commented 6 years ago

What macOS version was it created on?

robertjanetzko commented 6 years ago

10.13.2 and according to https://github.com/federkasten/appbundle-maven-plugin/blob/master/src/main/java/sh/tak/appbundler/CreateApplicationBundleMojo.java#L416 it just uses the hdiutil command.

robertjanetzko commented 6 years ago

@thecodewarrior which version of macOS are you trying to open it on? Seems the image uses APFS which probably won't work before 10.13

lethosor commented 6 years ago

Are you sure it's not making an APFS disk image or something like that, then? That wouldn't work on older versions as far as I know.

robertjanetzko commented 6 years ago

I changed the file system to HFS+ (hdiutil used APFS as default on 10.13) and updated the 1.17.1 image here and on DFFD. Let me know if the problem still exists.

thecodewarrior commented 6 years ago

Works perfectly now. 👍