robertjanetzko / LegendsBrowser

Legends Browser is an multi-platform, open source, java-based legends viewer for dwarf fortress 0.42.
MIT License
63 stars 19 forks source link

Support mercenary company honors for .47 #34

Closed therahedwig closed 4 years ago

therahedwig commented 4 years ago

I am just gonna add some issues here with the new legends stuff and samples. There's a looooot added, so gotta do this issue-by-issue.

[2020-01-31 20:51:14] WARNING: entity - unknown element: honor = 0

Used by mercenary companies. Samples:

<honor>
        <id>0</id>
        <name>Captain</name>
        <gives_precedence>100</gives_precedence>
        <requires_any_melee_or_ranged_skill/>
        <required_skill_ip_total>12600</required_skill_ip_total>
        <required_battles>4</required_battles>
        <required_years>10</required_years>
        <exempt_epid>0</exempt_epid>
        <exempt_former_epid>0</exempt_former_epid>
</honor>
<honor>
        <id>1</id>
        <name>Sword Master</name>
        <gives_precedence>110</gives_precedence>
        <required_skill>SWORD</required_skill>
        <required_skill_ip_total>12600</required_skill_ip_total>
</honor>
<honor>
        <id>2</id>
        <name>Sword Adept</name>
        <gives_precedence>210</gives_precedence>
        <required_skill>SWORD</required_skill>
        <required_skill_ip_total>5600</required_skill_ip_total>
</honor>

<honor>
        <id>0</id>
        <name>Captain</name>
        <gives_precedence>100</gives_precedence>
        <requires_any_melee_or_ranged_skill/>
        <required_skill_ip_total>12600</required_skill_ip_total>
        <required_battles>4</required_battles>
        <exempt_epid>0</exempt_epid>
        <exempt_former_epid>0</exempt_former_epid>
</honor>
<honor>
        <id>1</id>
        <name>Initiate</name>
        <granted_to_everybody/>
        <exempt_epid>0</exempt_epid>
        <exempt_former_epid>0</exempt_former_epid>
</honor>
<honor>
        <id>2</id>
        <name>Crossbow Master</name>
        <gives_precedence>110</gives_precedence>
        <required_skill>CROSSBOW</required_skill>
        <required_skill_ip_total>12600</required_skill_ip_total>
</honor>
therahedwig commented 4 years ago

fixed by https://github.com/robertjanetzko/LegendsBrowser/commit/9081c17dd6a13029c16e5df8b91400248d79c652