search

robertjanetzko / LegendsBrowser

Legends Browser is an multi-platform, open source, java-based legends viewer for dwarf fortress 0.42.
MIT License
63 stars 19 forks source link

Fix names of HF positions with static positions by race #43

Closed McArcady closed 4 years ago

McArcady commented 4 years ago

The names of positions (king, law-maker, druid, ...) are not provided anymore by events "create entity position". I replaced them by their static default names for each race (except necromancers).

therahedwig commented 4 years ago

I thought the human and goblin positions get generated now? meaning these names are not the only ones...

McArcady commented 4 years ago

Oh thanks, I overlooked that part. That explains the similarities between positions of goblins and humans in my world export. I propose we keep the positions for dwarves and elves (initially defined in the raws, but not available in the xml), and reduce positions for other races to 'law-giver' and 'master'.

therahedwig commented 4 years ago

If they used to be provided, maybe we should make a bugreport on the df mantis that it is now impossible to tell what kind of position changes took place?

McArcady commented 4 years ago

Ok I removed all static names for positions of goblins and humans that are now generated by the game.