Add class TV (any smart TV)

robertklep / name.klep.homekitty

HomeyKit 3.0

15 stars 5 forks source link

Add class TV (any smart TV) #71

Closed ecointet closed 1 year ago

ecointet commented 1 year ago

Type (brand/model) of device

Samsung Smart TV (Frame)

Homey Model

[X] "old" Homey (Pro)
[ ] Homey Pro 2023

Is it supported by HomeyKit?

[ ] Yes
[ ] No
[X] I don't know

Device Classes

Find the device here: https://tools.developer.homey.app/tools/devices

What are it's class, and virtual class (if it has one)?

Class: tv
Virtual Class:

Device Capabilities

(see above for where you can find these; please post ID, title and type)

onoff | Turned on | boolean
volume_up | Volume up | boolean
channel_up | Channel up | boolean
volume_down | Volume down | boolean
channel_down | Channel down | boolean
volume_mute | Volume muted | boolean
volume_set | Set volume | number

Expected result in Homekit:

IMG_2461E2C17B9F-1

robertklep commented 1 year ago

I'm looking to implement this, but not sure how to map the Homey capabilities to the HomeKit RemoteKey values: https://github.com/homebridge/HAP-NodeJS/blob/93a9743c6ae5b6ba3cb4949ef418341234812226/src/lib/definitions/CharacteristicDefinitions.ts#L3063

Any ideas?

ecointet commented 1 year ago

Not sure if someone is using the TV tile as a remote controller ( is this possible)? On my side, as a first implementation, only the Characteristic.Active is enough!

Displaying the TVs with the status (on/off) and be able to turn it on or off with Homekit is good enough.

robertklep commented 1 year ago

Test version should at least have partial support now: https://homey.app/a/name.klep.homekitty/test/

Thanks for your donation, by the way!

ecointet commented 1 year ago

Thanks for your donation, by the way

You are welcome, a very very small contribution 😅

The TVs are displayed as regular switches and not as TVs (cf my screenshot above).

There is 2 switches per TV as well, any reason ?

thanks!

ecointet commented 1 year ago

Actually it works well because the blue switch is recognized as a TV 👌🏻 No idea why there is a regular switch as well 😅

As a workaround I can do « show as separate tile » to get a unique tile for the TV. But i still have non-useful switch in that case

robertklep commented 1 year ago

I forgot to remove tv from the "generic onoff devices" list, so it was being mapped twice.

Fixed in v2.2.11: https://homey.app/a/name.klep.homekitty/test/

ecointet commented 1 year ago

Ah cool! Makes total sense :) now it is perfect :) I have a new icon with a home for the TV, never seen thay before, why not 😜😂

thanks 🙏