robertklep / quotefixformac

QuoteFix for Apple Mail —
https://github.com/robertklep/quotefixformac/releases/latest
191 stars 15 forks source link

macOS Sierra (Mail.app version 10) not supported #69

Closed andreastt closed 7 years ago

andreastt commented 8 years ago

After installing the add-on on macOS Sierra, an alert appears saying the bundle is not supported on Mail.app version 10 and to contact the author.

The bundle in ~/Library is subsequently deleted.

I have not yet investigated further.

robertklep commented 8 years ago

I'm not running Sierra myself, so can't offer a quick fix, but the first step to fixing this is usually to add the new Mail UUID to QuoteFix.mailbundle/Contents/Info.plist, as per this FAQ.

However, chances are that it still won't work, usually something breaks between major releases. I'll see if I can run Sierra in a VM.

alvarnell commented 8 years ago

Somebody else told me that MailPluginFix http://code2k.net/products/mailpluginfix/ did not work for another Mail Plugin, so chances are that something changed.

-Al-

On Mon, Jul 04, 2016 at 09:46 AM, Robert Klep wrote:

I'm not running Sierra myself, so can't offer a quick fix, but the first step to fixing this is usually to add the new Mail UUID to QuoteFix.mailbundle/Contents/Info.plist, as per this FAQ https://github.com/robertklep/quotefixformac/wiki/FAQ---Frequently-Asked-Questions#every-time-mac-os-x-updates-i-get-a-message-that-quotefix-is-disabled.

However, chances are that it still won't work, usually something breaks between major releases. I'll see if I can run Sierra in a VM.

atgmatt commented 8 years ago

Unfortunately just updating the SupportedPluginCompatibilityUUIDs list to include the new PluginCompatibilityUUID from Mail doesn't seem to work. I've tried it both through MailPluginFix and manually and in both cases Mail still complaints that the modified bundle isn't compatible with Mail 10.0

robertklep commented 8 years ago

First alpha release for Sierra support: v2.8.0-alpha.1

andreastt commented 7 years ago

@robertklep I can confirm that the alpha version works fine on macOS Sierra 10.12 Beta (16A239j).

Thanks so much! I tried your earlier suggestions, but I found the build system requirements and all the dependencies a bit much.

atgmatt commented 7 years ago

2.8.0-alpha.1 is working for me on macOS Sierra public beta 1. Thanks, Robert!

robertklep commented 7 years ago

@andreastt @atgmatt thanks for testing!

I'll close this issue, if any other issues pop up, feel free to open a new one.

atgmatt commented 7 years ago

@robertklep Out of curiosity, what did you have to change to make it work? There are a couple of other mail plugins I use heavily that don't work even after updating the Mail UUID, so I'm wondering if there's anything to learn from quotefix that might help the authors of those plugins.

robertklep commented 7 years ago

@atgmatt aside from having to add the new UUID (the procedure for which has changed slightly, see this commit), the main issue was with some code that I added once to improve compatibility with another plugin (Attachment Tamer).

Since that plugin has been discontinued, it was easiest to just remove that code (in this commit) instead of trying to work out why it was failing on Sierra. That was basically the only change I had to make to get it up and working again, although there still remains an issue with the "remove attachment placeholders" feature that I still have to look in to.

atgmatt commented 7 years ago

I'll bet if I manually hack the configurations of the other plugins to add the UUID to the new Supported10.12PluginCompatibilityUUIDs instead of the old SupportedPluginCompatibilityUUIDs that they start working. If so, I will report back to the others of those plugins. This is a great find and will probably save some people a ton of time in porting their plugins.

alvarnell commented 7 years ago

I don’t know that it will help, but MailPluginFix <http://code2k.net/products/mailpluginfix/ http://code2k.net/products/mailpluginfix/> was updated recently, though I don’t know for certain that it includes the 10.12 fix or not. Not a Sierra tester yet.

-Al-

On Tue, Jul 19, 2016 at 03:11 PM, atgmatt wrote:

@robertklep https://github.com/robertklep Out of curiosity, what did you have to change to make it work? There are a couple of other mail plugins I use heavily that don't work even after updating the Mail UUID, so I'm wondering if there's anything to learn from quotefix that might help the authors of those plugins.