robertklep / quotefixformac

QuoteFix for Apple Mail —
https://github.com/robertklep/quotefixformac/releases/latest
191 stars 15 forks source link

double signature in forwarded mails #87

Open marcscholl opened 6 years ago

marcscholl commented 6 years ago

I have the problem that forwarded mails get my signature appended twice when quote fixing is enabled.

I have multiple signatures in apple mail (one for each of multiple mail accounts), therefore I see a drop-down signature selector in the right above the mail text. When quotefixing for forwards is ON, my signature gets appended in the message pane, however the signature selector says "no signature". When I hit "send", a signature gets appended anyway, so finally, I send a mail with two signatures.

When I hold "alt" on the keyboard while forwarding (so as to temporarily disable quotefixing), the signature is also appended, BUT the signature selection box has the signature selected, so sending does not append another copy.

Any ideas? (BTW: with reply and reply-all everything works just fine) --Marc

robertklep commented 6 years ago

That's uhm interesting, especially since it only happens with Forwards and not with Reply/Reply-All (I don't think QF handles signatures differently depending on the type).

Do you use other Mail plugins?

marcscholl commented 6 years ago

Yes, I do. I’ve removed them to check: makes no difference.

I’ve enabled X.509 signing by default, disabling that is a bit more effort, hence I’ve not yet checked that…

—Marc

On Mon, Apr 09, 2018 at 15:03h, Robert Klep notifications@github.com wrote (with possible deletions):

That's uhm interesting, especially since it only happens with Forwards and not with Reply/Reply-All (I don't think QF handles signatures differently depending on the type).

Do you use other Mail plugins?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

-- Prof. Dr. Marc H. Scholl
Universitaet Konstanz
FB Informatik & Informationswissenschaft
D-78457 Konstanz, Germany
Tel: +49 (0)7531/88-4432, Fax: +49 (0)7531/88-3577
https://dbis.uni-konstanz.de
robertklep commented 6 years ago

What I find strange is 'When I hit "send", a signature gets appended anyway', which sounds like there might be another plugin inserting a signature (if there was, it might be some sort of interaction between that plugin and QF).

QF only removes signatures, and only from messages you received. It doesn't insert signatures itself, nor does it have any code that hooks into the signature-generating part of Mail.

So I'm a bit puzzled at the moment :(

marcscholl commented 6 years ago

Puzzling, indeed.

Tried the following:

  1. removed QF plugin: everything works as expected.

  2. with QF plugin again: second copy of signature is actually added when I hit return after entering the first recipient, not upon „send“. This occurs with only 1 out of 3 accounts.

  3. removed signature from Apple mail for the flawed account. Added one again. Same faulty behaviour as before.

Would turning on „debuging“ in the QF Advanced pref. pane be of any help? And where would the debug log end up?

Best —Marc

On Mon, Apr 09, 2018 at 15:16h, Robert Klep notifications@github.com wrote (with possible deletions):

What I find strange is 'When I hit "send", a signature gets appended anyway', which sounds like there might be another plugin inserting a signature (if there was, it might be some sort of interaction between that plugin and QF).

QF only removes signatures, and only from messages you received. It doesn't insert signatures itself, nor does it have any code that hooks into the signature-generating part of Mail.

So I'm a bit puzzled at the moment :(

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

-- Prof. Dr. Marc H. Scholl
Universitaet Konstanz
FB Informatik & Informationswissenschaft
D-78457 Konstanz, Germany
Tel: +49 (0)7531/88-4432, Fax: +49 (0)7531/88-3577
https://dbis.uni-konstanz.de
robertklep commented 6 years ago

Enabling debug logging might provide a clue. The log ends up in the system log, which you can access through the Console application.

marcscholl commented 6 years ago

All I see in system.log when searching for „quotefix“ is

Apr 9 15:55:25 phobos169 Mail[33942]: QuoteFix Plugin (version 2.9.0) registered with Mail.app Apr 9 15:55:34 phobos169 Mail[33942]: QuoteFixing done

doesn’t look like big insight.

On Mon, Apr 09, 2018 at 15:52h, Robert Klep notifications@github.com wrote (with possible deletions):

Enabling debug logging might provide a clue. The log ends up in the system log, which you can access through the Console application.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

robertklep commented 6 years ago

It logs more, but not all log lines are prefixed with "QuoteFix".

marcscholl commented 6 years ago

OK, here is some more:

Apr 9 16:03:14 phobos169 Mail[34676]: debug logging active Apr 9 16:03:14 phobos169 Mail[34676]: QuoteFix Plugin (version 2.9.0) registered with Mail.app Apr 9 16:03:14 phobos169 Mail[34676]: objc[34676]: Class MCCMailAbstractor is implemented in both /Users/scholl/Library/Mail/Bundles/MailFollowUp.mailbundle/Contents/MacOS/MailFollowUp (0x112903288) and /Users/scholl/Library/Mail/Bundles/MailFollowUp.mailbundle/Contents/MacOS/MailFollowUp (0x112903288). One of the two will be used. Which one is undefined. Apr 9 16:03:18 phobos169 systemstats[82]: assertion failed: 17E199: systemstats + 914800 [D1E75C38-62CE-3D77-9ED3-5F6D38EF0676]: 0x40 Apr 9 16:03:20 --- last message repeated 1 time --- Apr 9 16:03:20 phobos169 log[34705]: log run noninteractively, parent: 34704 (sh), args: '/usr/bin/log' 'stream' '--style' 'syslog' '--predicate' '(processImagePath contains "sshd")' Apr 9 16:03:20 phobos169 diagnosticd[315]: System mode client started - log (34705) - mode: 0x8 Apr 9 16:03:20 phobos169 diagnosticd[315]: System mode client stopped - log (34705) - clearing mode: 0x0, still active: 0xb Apr 9 16:03:20 phobos169 com.apple.xpc.launchd[1] (com.apple.imfoundation.IMRemoteURLConnectionAgent): Unknown key for integer: _DirtyJetsamMemoryLimit Apr 9 16:03:22 --- last message repeated 1 time --- Apr 9 16:03:22 phobos169 com.apple.xpc.launchd[1] (com.openssh.sshd.4A6CDDE8-3DF8-46CF-8ECC-2D1CBD3ABA03[34689]): Service exited with abnormal code: 255 Apr 9 16:03:22 phobos169 systemstats[82]: assertion failed: 17E199: systemstats + 914800 [D1E75C38-62CE-3D77-9ED3-5F6D38EF0676]: 0x40 Apr 9 16:03:26 phobos169 com.apple.xpc.launchd[1] (com.apple.preference.displays.MirrorDisplays): Service only ran for 0 seconds. Pushing respawn out by 10 seconds. Apr 9 16:03:26 phobos169 Mail[34676]: [ComposeViewController finishLoadingEditor] Apr 9 16:03:26 phobos169 Mail[34676]: calling customize_attribution() for forwarding Apr 9 16:03:26 phobos169 Mail[34676]: calling move_above_new_signature() Apr 9 16:03:26 phobos169 Mail[34676]: calling cleanup_layout() Apr 9 16:03:26 phobos169 Mail[34676]: calling view.moveToBeginningOfLine() Apr 9 16:03:26 phobos169 Mail[34676]: QuoteFixing done Apr 9 16:03:27 phobos169 Mail[34676]: [ComposeViewController show]

On Mon, Apr 09, 2018 at 15:59h, Robert Klep notifications@github.com wrote (with possible deletions):

It logs more, but not all log lines are prefixed with "QuoteFix".

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

-- Prof. Dr. Marc H. Scholl
Universitaet Konstanz
D-78457 Konstanz, Germany
Tel: +49 (0)7531/88-4432, Fax: +49 (0)7531/88-3577
https://dbis.uni-konstanz.de
robertklep commented 6 years ago

Thanks.

Sadly, it doesn't really provide any clues (I assume that you also tested with MailFollowUp moved out of ~/Library/Mail/Bundles/).

All I can say is try to disable/enable some options in QF (customized attributions, various Quotefixing settings) to see if there's a magic bullet.

marcscholl commented 6 years ago

Robert,

apparently it is to do with the concrete form of the signature. I don’t know what’s causing the trouble, but with a simplified version as included with this mail, the problem is gone. It’s not the „|“s per se, neither the „&“ nor blanks or some such at the beginning of lines, I’m tired of experimenting for today. Should I find out later, I’ll let you know.

Best —Marc

On Mon, Apr 09, 2018 at 16:15h, Robert Klep notifications@github.com wrote (with possible deletions):

Thanks.

Sadly, it doesn't really provide any clues (I assume that you also tested with MailFollowUp moved out of ~/Library/Mail/Bundles/).

All I can say is try to disable/enable some options in QF (customized attributions, various Quotefixing settings) to see if there's a magic bullet.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

-- Prof. Dr. Marc H. Scholl

Universitaet Konstanz FB Informatik & Informationswissenschaft D-78457 Konstanz, Germany Tel: +49 (0)7531/88-4432, Fax: +49 (0)7531/88-3577 https://dbis.uni-konstanz.de