search

robertkrimen / otto

A JavaScript interpreter in Go (golang)
http://godoc.org/github.com/robertkrimen/otto
MIT License
8.11k stars 586 forks source link

Go 1.15: conversion from int to string yields a string of one rune #384

Closed eclipseo closed 3 years ago

eclipseo commented 4 years ago

Go 1.15 rc 1 on Fedora Rawhide:

Testing    in: /builddir/build/BUILD/otto-c382bd3c16ff2fef9b5fe0dd8bf4c4ec6bfe62c1/_build/src
         PATH: /builddir/build/BUILD/otto-c382bd3c16ff2fef9b5fe0dd8bf4c4ec6bfe62c1/_build/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin
       GOPATH: /builddir/build/BUILD/otto-c382bd3c16ff2fef9b5fe0dd8bf4c4ec6bfe62c1/_build:/usr/share/gocode
  GO111MODULE: off
      command: go test -buildmode pie -compiler gc -ldflags "-X github.com/robertkrimen/otto/version=0 -X github.com/robertkrimen/otto/version.commit=c382bd3c16ff2fef9b5fe0dd8bf4c4ec6bfe62c1 -extldflags '-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '"
      testing: github.com/robertkrimen/otto
github.com/robertkrimen/otto
# github.com/robertkrimen/otto
./builtin.go:51:16: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
./builtin.go:53:16: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
./builtin.go:53:35: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
./regexp_test.go:259:15: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
FAIL    github.com/robertkrimen/otto [build failed]

See https://github.com/golang/go/issues/32479