search

robertkrimen / otto

A JavaScript interpreter in Go (golang)
http://godoc.org/github.com/robertkrimen/otto
MIT License
8.01k stars 584 forks source link

Support Object.values() #518

Closed rorymalcolm closed 4 months ago

rorymalcolm commented 4 months ago

This adds support for Object.values(), alongside tests

rorymalcolm commented 4 months ago

It seems likely we need to bump the Go version of this project - I can do that this week

rorymalcolm commented 4 months ago

Thanks for the PR, some small tweaks to improve maintainability.

Applied!

stevenh commented 4 months ago

Could you rebase to pickup the fix for the check failures please @rorymalcolm

rorymalcolm commented 4 months ago

Could you rebase to pickup the fix for the check failures please @rorymalcolm

Done - was going to try get https://github.com/rorymalcolm/otto/pull/1 up today but you beat me to it - thanks so much!