Closed robertlipe closed 1 year ago
@davepl , I borked the commit (oops) but include/effects/matrix/PatternSMBAurora.h has a somewhat reasonable (maybe) start on what I think should be needed for the constructor changes you're asking. (I moved a chunk of code - the change is smaller than it looks) but I don't get effects list joy.
I'd hoped I could do something like this in effects.cc
ADD_EFFECT(EFFECT_MATRIX_SMSTARDEEP, PatternSMStarDeep);
// ADD_EFFECT(EFFECT_MATRIX_SMNOISE, PatternSMNoise); ADD_EFFECT(EFFECT_MATRIX_SMNOISE, PatternSMNoise, "Lava Rainbow", PatternSMNoise::EffectType::LavaLampRainbow); ADD_EFFECT(EFFECT_MATRIX_SMNOISE, PatternSMNoise, "Lava Rainbow Stripe", PatternSMNoise::EffectType::LavaLampRainbowStripe); ADD_EFFECT(EFFECT_MATRIX_SMNOISE, PatternSMNoise, "Shikon", PatternSMNoise::EffectType::Shikon); ADD_EFFECT(EFFECT_MATRIX_SMNOISE, PatternSMNoise, "ColorCube", PatternSMNoise::EffectType::ColorCube); ADD_EFFECT(EFFECT_MATRIX_SM2DDPR, PatternSM2DDPR);
And then get four entries in the effects list that shows up in the web interface. Clearly, I'm missing something.
Do you wanna take a turn on this one? I'll come back and learn the needed chant so I can do it to a few of the others that we've talked about.
Dave selected some subset of styles. Neesd new constructors and plumbing in effects.cpp so select them.