Open weishuaikun opened 6 years ago
spyoungtech
commented
6 years ago Can you elaborate on why this change is needed? Your suggestion seems like it would not match the other APIs.
Looking at the other boxes in derived_boxes.py, they all follow pretty much the same signature of
def box(msg="", title=" ", other_keywords)So why the change here?
weishuaikun
commented
6 years ago so other boxes in derived_boxes.py follow pretty much the same signature of
def box(msg="", title=" ", other_keywords)
but in the body of the function we can see
return tb.textbox(msg, title, text, codebox=True)
codebox and other is call tb.textbox to implement，but when we see the tb.textbox
def textbox(msg="", text="", title=" ", codebox=False, callback=None, run=True):
we find
msg = msg ; text = title ; title = text;
so i suggest change the pretty name.
in derived_boxes.py , one api need to be change!
def codebox(msg="", title=" ", text="") need to be changed as: def codebox(msg="",text="",title="")