include README.md in sdist

robertlugg / easygui

easygui for Python

http://easygui.readthedocs.org/en/master/

BSD 3-Clause "New" or "Revised" License

458 stars 115 forks source link

include README.md in sdist #181

Closed dotlambda closed 2 years ago

dotlambda commented 3 years ago

Otherwise build fails with

FileNotFoundError: [Errno 2] No such file or directory: 'README.md'

It would be nice if you could make a new release that includes README.md.

zadacka commented 2 years ago

Agreed - this is referenced in setup.py so needs to be in the manifest or causes problems at build time.

zadacka commented 2 years ago

Turns out that I needed to add the README.md entry as an include command to the manually created MANIFEST.in - see PR #196 ... rather than adding it to the automatically created MANIFEST file.

This seems to be okay (I've just used it to build a new version of easygui, v0.98.3). Please let me know if you spot any issues...

dotlambda commented 2 years ago

Thank you, it works flawlessly!

zadacka commented 2 years ago

Thank you for confirming (and for your patience)! 😅

On Sun, 3 Apr 2022 at 03:29, Robert Schütz @.***> wrote:

Thank you, it works flawlessly!

— Reply to this email directly, view it on GitHub https://github.com/robertlugg/easygui/pull/181#issuecomment-1086763039, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2XZILBVBUN5BD5DUHRK3DVDD7ALANCNFSM4ZTARXCA . You are receiving this because you modified the open/close state.Message ID: @.***>