search

robertmarsal / lolcatjs

For the lols
Other
110 stars 10 forks source link

TrueColor on Mac and Return Prompt after animation #12

Closed shelldandy closed 7 years ago

shelldandy commented 7 years ago

💅

shelldandy commented 7 years ago

Also added a better color checker dependency

https://github.com/chalk/supports-color

robertmarsal commented 7 years ago

Hi @mike3run, thank you very much for this. The code changes look great, and are probably more compatible with the systems out there, but can you please reverse the formatting changes from the last commit? I am happy with how the formatting was previously.

Regards, Rob

shelldandy commented 7 years ago

It's fine, really https://standardjs.com

https://www.youtube.com/watch?v=Qlr-FGbhKaI http://blog.izs.me/post/2353458699/an-open-letter-to-javascript-leaders-regarding http://inimino.org/~inimino/blog/javascript_semicolons https://www.youtube.com/watch?v=gsfbh17Ax9I

shelldandy commented 7 years ago

sadddd

Going back now

shelldandy commented 7 years ago

All set @robertboloc

robertmarsal commented 7 years ago

Amazing! Thank you so much for your contribution. I will look into the standardjs.com recommendation and see if I can adopt it for my projects :+1: