search

robertmarsal / lolcatjs

For the lols
Other
110 stars 10 forks source link

Add a "files" section to package.json #14

Closed vsa closed 7 years ago

vsa commented 7 years ago

This saves downloading the images in the "assets" directory when the package is installed via npm. If you prefer having them there please just reject this pull request.

robertmarsal commented 7 years ago

Thank you, I didn't knew you could do this. I don't think it's necessary to download anything else besides the source code.

Thank you for both of your contributions :)

vsa commented 7 years ago

Thanks a lot for merging. I noticed that a new version (v2.3.0) is available on GitHub https://github.com/robertboloc/lolcatjs/releases, but not on npm https://www.npmjs.com/package/lolcatjs. Did something go wrong?

On Mon, Aug 21, 2017 at 9:15 PM, Robert Boloc notifications@github.com wrote:

Merged #14 https://github.com/robertboloc/lolcatjs/pull/14.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/robertboloc/lolcatjs/pull/14#event-1214684178, or mute the thread https://github.com/notifications/unsubscribe-auth/AANlt2lEgoB_7WnPF1iiE6K0KKJ11dI6ks5saddMgaJpZM4O8Wqn .

robertmarsal commented 7 years ago

@vsa sorry about that, forgot to npm publish. It should be there now.

vsa commented 7 years ago

Yes, my terminal just became more colorful. Thanks again!