search

robertmarsal / lolcatjs

For the lols
Other
110 stars 10 forks source link

Update dependencies. Use template literal instead of multiline. #18

Closed scotttesler closed 4 years ago

scotttesler commented 4 years ago

Problems

1

On the latest version of Node, the sleep module throws errors during installation. Thus, animation is not available.

Screen Shot 2020-02-19 at 8 37 07 PM

Feb-19-2020 21-02-20

2

The multiline module is now deprecated and the repository is archived. When installed, it gives the following warning:

npm WARN deprecated multiline@2.0.0: This was a fun hack, but now we have template literals, so use that instead.

3

The cursor disappears after printing piped-in input.

no cursor

Solutions

1

Update dependencies to their latest versions.

Screen Shot 2020-02-19 at 8 51 27 PM

animation works

2

Use a template literal instead of multiline.

Screen Shot 2020-02-19 at 8 41 07 PM

3

Show cursor after printing the piped-in input.

cursor is back

robertmarsal commented 4 years ago

Hi @scotttesler thank you very much for the detailed report and fixes. I will get this merged and published asap.

Regards, Rob