search

robertmartin8 / MachineLearningStocks

Using python and scikit-learn to make stock predictions
MIT License
1.74k stars 506 forks source link

update function build_dataset_iteratively to reflect taking start symbol and end symbol for range download #25

Closed GuangMo closed 5 years ago

GuangMo commented 5 years ago

sorry Robert, I accidentally "commit -a -m" to include the stock csv, and I only have another hour to play on GitHub today, so I did not revert my change and redo them again, please feel free to only modify the change on your function and abandon the PR. Great work by the way!

robertmartin8 commented 5 years ago

@GuangMo My apologies for the late response – I will review the modifications and try to merge them some time this coming week

robertmartin8 commented 5 years ago

@GuangMo I have reviewed it – I understand what you are trying to do, but I think this should be a new function rather than overwriting the current one

GuangMo commented 5 years ago

Sounds good, Robert! I will leave it up to you then :)

Sent from my iPhone

On Mar 14, 2019, at 9:43 AM, Robert Martin notifications@github.com wrote:

@GuangMo I have reviewed it – I understand what you are trying to do, but I think this should be a new function rather than overwriting the current one

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.